ClintchizandClaude Opus 5
e01915823a
Brings the uncommitted body of work under version control so it cannot be
lost. Gates are green: 152 tests pass across rpc/router/dev-server,
typecheck, lint, format and check:public-api all clean.
NOT YET REVIEWED. None of Tasks 5-11 has had an independent task review, and
Task 4's second fix round was never re-reviewed either.
Known gaps against the plan, recorded here rather than discovered later:
- packages/rpc/test/{transport,server,client}.test.ts are ABSENT. The plan
required a test file for each. server.ts holds the fail-closed identity and
permission checks and currently has no direct coverage at all.
- rpc-endpoint.test.ts has 3 tests where the plan specified 9. Missing:
unknown service, non-POST, malformed body, non-rpc passthrough, and the
isInternalCaller sweep. This is the task where a reachable
/__wrnexus/rpc/* makes every permission check in the workspace bypassable.
- http.test.ts has 3 of 7; integration.test.ts 2 of 3;
services-discovery.test.ts 1 of 4.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
46 lines
1.9 KiB
TypeScript
46 lines
1.9 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import { RPC_ERROR_CODES } from "../src/errors.ts";
|
|
import { RPC_IDENTITY_HEADER } from "../src/identity.ts";
|
|
import { httpTransport, rpcPath } from "../src/http.ts";
|
|
|
|
const target = { app: "billing", service: "billing", procedure: "createInvoice" };
|
|
|
|
function transportWith(handler: (request: Request) => Response | Promise<Response>) {
|
|
return httpTransport({
|
|
resolveOrigin: () => "http://billing.test",
|
|
fetch: (async (input: RequestInfo | URL, init?: RequestInit) =>
|
|
handler(new Request(input, init))) as typeof fetch,
|
|
});
|
|
}
|
|
|
|
describe("httpTransport", () => {
|
|
test("posts to the private endpoint with identity", async () => {
|
|
const transport = transportWith(async (request) => {
|
|
expect(request.url).toBe("http://billing.test/__wrnexus/rpc/billing/createInvoice");
|
|
expect(request.headers.get(RPC_IDENTITY_HEADER)).toBe("token");
|
|
expect(request.headers.get("x-wrnexus-internal")).toBe("1");
|
|
expect(await request.json()).toEqual({ amountCents: 5 });
|
|
return Response.json({ ok: true, value: { invoiceId: "inv_1" } });
|
|
});
|
|
expect(await transport.call(target, { amountCents: 5 }, { identity: "token" })).toEqual({
|
|
ok: true,
|
|
value: { invoiceId: "inv_1" },
|
|
});
|
|
});
|
|
|
|
test("classifies unavailable and malformed responses safely", async () => {
|
|
const unavailable = transportWith(() => new Response("busy", { status: 503 }));
|
|
const failed = await unavailable.call(target, {}, {});
|
|
expect(failed).toMatchObject({ code: RPC_ERROR_CODES.transport, retryable: true });
|
|
const malformed = transportWith(() => Response.json({ hello: "world" }));
|
|
expect(await malformed.call(target, {}, {})).toMatchObject({
|
|
code: RPC_ERROR_CODES.malformed,
|
|
retryable: false,
|
|
});
|
|
});
|
|
|
|
test("uses the stable reserved path", () => {
|
|
expect(rpcPath("billing", "createInvoice")).toBe("/__wrnexus/rpc/billing/createInvoice");
|
|
});
|
|
});
|