ClintchizandClaude Opus 5
c7ab605e85
Section, SectionHeader and PublicPageShell move onto wire-* classes with local style blocks, variants as data attributes. SectionHeader loses 38 utility lines, and Section stops spending one line per variant and colour pairing: tinted and solid now select on two attributes. PageHeader was already on the convention and only needed the audit. examples/basic-app/app/pages/layout.wrn composes the whole set into one page. Building it surfaced a library-wide bug. Ten custom properties were referenced by components and defined by nothing: --wire-color-focus, --wire-color-surface-soft, --wire-color-on-danger, --wire-color-surface-subtle and the input-* family, plus hover and contrast for every semantic colour except primary and secondary. An undefined custom property does not warn, it resolves to nothing, so focus rings drew with no colour and every soft surface rendered transparent -- 27 components referenced surface-soft alone. They are derived in the theme now, and a test checks every token a component references against the rendered theme CSS rather than the source, since most are generated. The semantic spread also had to move ahead of the primary and secondary entries so the palette keeps winning for those two. Known and unresolved: LayoutSplitter emits its sizeChange output and the component does fire it, but a parent binding on the tag is not invoked. The tour page therefore points at the handle aria-valuenow rather than wiring a handler that would never update. Outputs work elsewhere, so this is narrower than an outputs-are-broken problem and needs its own investigation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
133 lines
3.1 KiB
Plaintext
133 lines
3.1 KiB
Plaintext
component PublicPageShell {
|
|
props {
|
|
maxWidth: string = "full"
|
|
fullWidth: boolean = true
|
|
headerOffset: string = "none"
|
|
background: string = "default"
|
|
overflow: string = "clip"
|
|
minHeight: string = "screen"
|
|
size: string = "default"
|
|
color: string = "primary"
|
|
variant: string = "default"
|
|
class: string = ""
|
|
}
|
|
|
|
view {
|
|
<div
|
|
{...attrs}
|
|
data-ui-component="PublicPageShell"
|
|
class='wire-page-shell {class}'
|
|
data-size='{size}'
|
|
data-color='{color}'
|
|
data-variant='{variant}'
|
|
data-background='{background}'
|
|
data-overflow='{overflow}'
|
|
data-min-height='{minHeight}'
|
|
data-header-offset='{headerOffset}'
|
|
>
|
|
<slot name="before"></slot>
|
|
|
|
<main
|
|
class="wire-page-shell__main"
|
|
data-full-width='{fullWidth}'
|
|
data-max-width='{maxWidth}'
|
|
>
|
|
<slot></slot>
|
|
</main>
|
|
|
|
<slot name="after"></slot>
|
|
</div>
|
|
}
|
|
|
|
style {
|
|
.wire-page-shell {
|
|
position: relative;
|
|
isolation: isolate;
|
|
width: 100%;
|
|
min-width: 0;
|
|
color: var(--wire-color-text);
|
|
background: var(--wire-color-background);
|
|
}
|
|
|
|
.wire-page-shell[data-background="soft"] {
|
|
background: var(--wire-color-surface-soft);
|
|
}
|
|
|
|
.wire-page-shell[data-background="raised"] {
|
|
background: var(--wire-color-surface-raised);
|
|
}
|
|
|
|
.wire-page-shell[data-min-height="screen"] {
|
|
min-height: 100vh;
|
|
}
|
|
|
|
/*
|
|
* dvh tracks the browser chrome on a phone, so a full-height shell does
|
|
* not leave a gap when the address bar collapses.
|
|
*/
|
|
.wire-page-shell[data-min-height="dvh"] {
|
|
min-height: 100dvh;
|
|
}
|
|
|
|
.wire-page-shell[data-overflow="clip"] {
|
|
overflow-x: clip;
|
|
}
|
|
|
|
.wire-page-shell[data-overflow="hidden"] {
|
|
overflow-x: hidden;
|
|
}
|
|
|
|
/*
|
|
* One main element rather than a branch per width. fullWidth is an
|
|
* attribute, so the width cap and the gutters are a couple of rules
|
|
* instead of two copies of the same markup.
|
|
*/
|
|
.wire-page-shell__main {
|
|
width: 100%;
|
|
min-width: 0;
|
|
}
|
|
|
|
.wire-page-shell__main[data-full-width="false"] {
|
|
margin-inline: auto;
|
|
padding-inline: 1rem;
|
|
}
|
|
|
|
.wire-page-shell__main[data-full-width="false"][data-max-width="lg"] {
|
|
max-width: 64rem;
|
|
}
|
|
|
|
.wire-page-shell__main[data-full-width="false"][data-max-width="xl"] {
|
|
max-width: 80rem;
|
|
}
|
|
|
|
.wire-page-shell__main[data-full-width="false"][data-max-width="2xl"] {
|
|
max-width: 96rem;
|
|
}
|
|
|
|
@media (min-width: 640px) {
|
|
.wire-page-shell__main[data-full-width="false"] {
|
|
padding-inline: 1.5rem;
|
|
}
|
|
}
|
|
|
|
@media (min-width: 1024px) {
|
|
.wire-page-shell__main[data-full-width="false"] {
|
|
padding-inline: 2rem;
|
|
}
|
|
}
|
|
|
|
/* Room for a fixed header to sit over the top of the shell. */
|
|
.wire-page-shell[data-header-offset="sm"] {
|
|
padding-top: 4rem;
|
|
}
|
|
|
|
.wire-page-shell[data-header-offset="md"] {
|
|
padding-top: 5rem;
|
|
}
|
|
|
|
.wire-page-shell[data-header-offset="lg"] {
|
|
padding-top: 6rem;
|
|
}
|
|
}
|
|
}
|