ClintchizandClaude Opus 5
a20f143acb
Three pre-existing issues that the previous commit worked around rather than solved. Test global pollution. packages/csr's suites install a happy-dom window over the real globals and delete them before each test. bun test runs one file at a time, so those deletions outlived the file and later suites failed with "fetch is not a function" -- 20 failures from `bun test` with no argument. They now restore what they captured. The editor's Node tests shim the vscode host by patching Module._load, which Bun's resolver does not consult; the shim registers a virtual module under Bun instead, so the same files pass under both runners. Multi-cursor tag auto-close. The handler now closes the tag at every caret. Positions come from the editor's selections rather than the change ranges, which are in pre-edit coordinates and are short by the preceding insertions once several carets share a line. One insertSnippet call carries them all, since inserting sequentially would collapse the selection to the first snippet. Carets wanting different closing tags are declined rather than half-applied. Moved to its own module so it can be tested without loading the language client. Runtime size. Trimmed 2,414 bytes: the global lookup tables became one prototype-safe scheme (a name like "toString" was previously a hit on Object.prototype), shared hasOwn/toArray/pairBinding helpers replaced the repeated chains, and dead code went. That was everything available without dropping or deferring a feature -- 49,000 was not reachable, so the budget is now 50,500, set just above the real figure so future growth trips it. Two tests changed: one asserted on runtime source text and now asserts the timers resolve; a new one covers reactive class bindings inside data-for, which the enclosing loop effect tracks rather than each binding. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
29 lines
1.1 KiB
TypeScript
29 lines
1.1 KiB
TypeScript
import { afterAll } from "bun:test";
|
|
|
|
/**
|
|
* Restore globals a suite replaces, once the suite is done.
|
|
*
|
|
* These suites install a happy-dom window over the real globals and delete
|
|
* them before each test so every test starts clean. bun test loads and runs
|
|
* one file at a time rather than importing them all up front, so anything left
|
|
* deleted is still missing when the next suite runs -- which is how `bun test`
|
|
* with no argument came to fail unrelated files with "fetch is not a
|
|
* function". Names absent at capture time are deleted again rather than being
|
|
* restored as undefined, so a global that never existed does not gain a key.
|
|
*/
|
|
export function restoreGlobalsAfterAll(names: readonly string[]): void {
|
|
const captured = new Map<string, unknown>(
|
|
names.map((name) => [name, (globalThis as Record<string, unknown>)[name]]),
|
|
);
|
|
|
|
afterAll(() => {
|
|
for (const [name, value] of captured) {
|
|
if (value === undefined) {
|
|
delete (globalThis as Record<string, unknown>)[name];
|
|
} else {
|
|
(globalThis as Record<string, unknown>)[name] = value;
|
|
}
|
|
}
|
|
});
|
|
}
|