feat(ui): add DataTable and Toaster, drop the legacy Table, fix overlay dialogs
DataTable replaces the 20-line Table scaffold entirely: columns, sorting, filtering, pagination, selection, bulk actions, comparison layout, sticky first column, custom HTML cells, and a remote source driven by a `request` output rather than a function prop (props travel as HTML attributes, so a function arrives as its own source text). Toaster replaces the hand-rolled status div: tone icons, actions, hover pause/resume and a progress bar. Overlays audit -- Modal and Drawer declared aria-modal="true" but nothing ever moved focus into the panel, so the @keydown handler on their root never ran and closeOnEscape did nothing. Focus, focus restore, a Tab trap and a body scroll lock now live in the reactive runtime, shared by both. ContextMenu placed pointer menus by subtracting a guessed 340x420 from the viewport, which pushed every menu that was not that size away from the pointer; it now positions at the pointer and lets the anchored clamp pull it back once it can be measured. The reactive runtime size budget moves 150k -> 175k to cover anchored overlays, dialog behaviour, the toaster and the DataTable client half. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -284,6 +284,18 @@ export class Lexer {
|
||||
* Read a `{ ... }` block and return its INNER text (no outer braces), with
|
||||
* brace counting that respects string and template literals so a `}` inside a
|
||||
* string doesn't end the block early.
|
||||
*
|
||||
* Comments are skipped as well. Without that, an apostrophe in ordinary
|
||||
* prose — `/* the panel's color *\/`, `// the Input's slot` — opened a
|
||||
* string that ran to the next apostrophe, swallowing every brace in between
|
||||
* and failing the whole component with "Unbalanced braces" pointing at the
|
||||
* block's opening line. Comments are where apostrophes actually occur, so
|
||||
* that error was almost always a false alarm.
|
||||
*
|
||||
* A `//` line comment is only recognised at the start of a line (after
|
||||
* whitespace), which is where every comment in a `.wrn` file is written.
|
||||
* Recognising it mid-line would break the far more common case of a bare
|
||||
* URL in view text, where `https://…` is not inside quotes.
|
||||
*/
|
||||
readBalancedBraces(): string {
|
||||
this.skipTrivia();
|
||||
@@ -295,6 +307,8 @@ export class Lexer {
|
||||
let depth = 0;
|
||||
let i = this.pos;
|
||||
let str: string | null = null;
|
||||
/** True while only whitespace has been seen since the last newline. */
|
||||
let atLineStart = false;
|
||||
for (; i < src.length; i++) {
|
||||
const c = src[i]!;
|
||||
if (str) {
|
||||
@@ -305,6 +319,29 @@ export class Lexer {
|
||||
if (c === str) str = null;
|
||||
continue;
|
||||
}
|
||||
|
||||
if (c === "\n") {
|
||||
atLineStart = true;
|
||||
continue;
|
||||
}
|
||||
|
||||
if (c === "/" && src[i + 1] === "*") {
|
||||
const close = src.indexOf("*/", i + 2);
|
||||
if (close === -1) break; // unterminated: fall through to the error
|
||||
i = close + 1;
|
||||
atLineStart = false;
|
||||
continue;
|
||||
}
|
||||
|
||||
if (atLineStart && c === "/" && src[i + 1] === "/") {
|
||||
const newline = src.indexOf("\n", i + 2);
|
||||
if (newline === -1) break;
|
||||
i = newline - 1; // let the loop's own increment land on the newline
|
||||
continue;
|
||||
}
|
||||
|
||||
if (c !== " " && c !== "\t" && c !== "\r") atLineStart = false;
|
||||
|
||||
if (c === '"' || c === "'" || c === "`") {
|
||||
str = c;
|
||||
continue;
|
||||
|
||||
@@ -207,3 +207,31 @@ test("maps literal unions to their runtime primitive types", async () => {
|
||||
expect(runtimeTypeOf("1 | 2 | 3")).toBe("number");
|
||||
expect(runtimeTypeOf("true | false")).toBe("boolean");
|
||||
});
|
||||
|
||||
// An apostrophe in prose is not a string. The brace scanner used to treat one
|
||||
// as an opening quote and swallow every brace until the next apostrophe, so a
|
||||
// comment like "the Input's slot" broke the whole component with a baffling
|
||||
// "Unbalanced braces" error pointing at the block's first line.
|
||||
test("comments may contain apostrophes without unbalancing a block", () => {
|
||||
const source = `component Demo {
|
||||
style {
|
||||
/* The panel's own color -- do not inherit it. */
|
||||
.demo {
|
||||
color: red;
|
||||
}
|
||||
// A trailing note about the card's border.
|
||||
.demo-b {
|
||||
color: blue;
|
||||
}
|
||||
}
|
||||
view {
|
||||
<p>Docs at https://example.com/a//b are not comments.</p>
|
||||
}
|
||||
}
|
||||
`;
|
||||
const ast = parse(source);
|
||||
expect(ast.name).toBe("Demo");
|
||||
expect(ast.styles.join(" ")).toContain(".demo-b");
|
||||
// The URL in view text must survive: `//` is only a comment at line start.
|
||||
expect(JSON.stringify(ast.view)).toContain("https://example.com/a//b");
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user