fix(csr,ui): deliver component outputs to parent bindings
Quality / quality (ubuntu-latest) (push) Failing after 13m39s
Quality / quality (windows-latest) (push) Canceled after 0s

An output only reaches a parent @binding when the component calls
output.<name>(). Two separate faults meant most of the library never got
there, and both failed silently at each end.

HTML lowercases attribute names, so a parent's @sizeChange registered under
"sizechange" while the component emitted "sizeChange". The lookup missed, fell
through to a DOM dispatch, and the binding was never invoked. That made all 17
camelCase outputs undeliverable -- DataTable.pageChange and .rowClick,
Map.markerClick, ChatBubble.messageClick, LayoutSplitter.sizeChange and the
rest. invokeComponentOutput now falls back to a case-insensitive lookup, and a
csr test fails without it.

Separately, 18 components dispatched hand-built CustomEvents rather than
calling output.*. A bubbling event on the component's own root never reaches a
binding, because parent handlers live in a registry only the output proxy
reads. Card, Footer, Breadcrumb, Accordion, alert, Badge, AnnouncementBar,
AvatarGroup, ToggleCount and InputNumber now emit properly; Marquee, Map,
Timeline, List and SearchBox additionally declare the outputs they were
already firing. Dispatches on window are left alone -- that is how Toaster,
Modal and DataTable signal across component boundaries.

Verified in a browser both ways before and after: an AnnouncementBar
dispatching its own bubbling "dismiss" never reached a page-level @dismiss,
and reached it immediately once it called output.dismiss().

This corrects the audit, which called the LayoutSplitter failure "narrow and
unexplained" and read 32 dead outputs as 16 components needing a rebuild.
"Outputs work elsewhere" was an assumption; the components that worked
happened to use lowercase names and output.*. The dead-output ratchet drops
from 32 to 22, and a new test forbids the raw-CustomEvent pattern outright.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-09 01:40:39 +05:30
co-authored by Claude Opus 5
parent 84dc4e06a2
commit 5e65627305
24 changed files with 384 additions and 224 deletions
+27 -1
View File
@@ -2033,11 +2033,37 @@ const MIGRATIONS: Migration[] = [
version: "0.8.6",
id: "0.8.6-navigation-and-layout-groups",
description:
"Rebuilds the navigation and layout component groups, moves them off Tailwind utilities onto wire-* classes, and defines theme tokens that components referenced but nothing declared.",
"Rebuilds the navigation and layout component groups, moves them off Tailwind utilities onto wire-* classes, defines theme tokens that components referenced but nothing declared, and makes component outputs actually reach parent bindings.",
apply() {
// Source changes no codemod can make safely, so they are listed rather
// than attempted.
//
// OUTPUTS NOW ARRIVE. Two faults kept declared outputs from reaching a
// parent @binding, and both are fixed. Expect handlers that never ran
// before to start running -- this is the intended repair, but it is a
// behaviour change in code you may have written around.
//
// 1. Every camelCase output was undeliverable. HTML lowercases
// attribute names, so @sizeChange registered as "sizechange" while
// the component emitted "sizeChange" and the lookup missed. That
// covered all 17 camelCase outputs, including DataTable.pageChange
// and .rowClick, Map.markerClick, ChatBubble.messageClick and
// LayoutSplitter.sizeChange. The runtime now matches case
// insensitively.
//
// 2. Eighteen components dispatched hand-built CustomEvents instead of
// calling output.*, which never reaches a binding. Card, Footer,
// Breadcrumb, Accordion, alert, Badge, AnnouncementBar, AvatarGroup,
// ToggleCount and InputNumber now emit properly.
//
// If you worked around the old silence by listening for the raw DOM
// event on the element, that listener still fires for cases where no
// binding is registered, but the supported route is the @binding.
//
// Marquee, Map, Timeline, List and SearchBox now DECLARE the outputs
// they were already firing: pause/resume, markerClick/select/zoom,
// select, select and search/clear respectively.
//
// Tabs replaced its raw CustomEvents with declared outputs. Code
// listening for the old change and select events on the element must
// move to the @change and @select bindings.