WorkRoot/WRNexusJS
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ui): render navbar brand prop outside slot
Quality / quality (ubuntu-latest) (push) Failing after 10m32s
Details
Quality / quality (windows-latest) (push) Canceled after 0s
Details

Browse Source
This commit is contained in:
Clintchiz
2026-08-25 14:00:46 +05:30
parent 64db7da08d
commit 3cb6ba1233
4 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bun.lock
+1 -1
View File
@@ -688,7 +688,7 @@
}, },
"packages/ui": { "packages/ui": {
"name": "@wrnexus/ui", "name": "@wrnexus/ui",
"version": "0.8.43", "version": "0.8.44",
"dependencies": { "dependencies": {
"@wrnexus/core": "workspace:*", "@wrnexus/core": "workspace:*",
}, },
packages/ui/components/Navbar.wrn
+1 -2
View File
@@ -171,7 +171,6 @@ size: string = "default"
</div> </div>
<div class="wrn-navbar__main"> <div class="wrn-navbar__main">
<slot name="brand">
{#if brand.logo || brand.icon || brand.label || brand.description} {#if brand.logo || brand.icon || brand.label || brand.description}
<a class="wrn-navbar__brand" href="{brand.href || '/'}" aria-label="{brand.ariaLabel || brand.label || label}"> <a class="wrn-navbar__brand" href="{brand.href || '/'}" aria-label="{brand.ariaLabel || brand.label || label}">
{#if brand.logo} {#if brand.logo}
@@ -188,7 +187,7 @@ size: string = "default"
{/if} {/if}
</a> </a>
{/if} {/if}
</slot> <slot name="brand" />
<div class="wrn-navbar__collapse {mobileOpen ? 'is-open' : ''}"> <div class="wrn-navbar__collapse {mobileOpen ? 'is-open' : ''}">
<nav class="wrn-navbar__menus" aria-label="{label}" data-wrn-roving="horizontal"> <nav class="wrn-navbar__menus" aria-label="{label}" data-wrn-roving="horizontal">
packages/ui/package.json
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "@wrnexus/ui", "name": "@wrnexus/ui",
"version": "0.8.43", "version": "0.8.44",
"private": true, "private": true,
"type": "module", "type": "module",
"main": "src/index.ts", "main": "src/index.ts",
packages/ui/test/ui-redesign-contract.test.ts
+5 -2
View File
@@ -126,11 +126,14 @@ describe("@wrnexus/ui redesign component pack", () => {
expect(source).not.toContain(".wrn-navbar__topbar:not(:empty)"); expect(source).not.toContain(".wrn-navbar__topbar:not(:empty)");
}); });
test("Navbar exposes a brand slot while retaining the brand prop fallback", async () => { test("Navbar renders its brand prop independently from the optional brand slot", async () => {
const source = await readFile(join(componentsDir, "Navbar.wrn"), "utf8"); const source = await readFile(join(componentsDir, "Navbar.wrn"), "utf8");
expect(source).toContain('<slot name="brand">'); expect(source).toContain('<slot name="brand" />');
expect(source).toContain("brand.logo || brand.icon || brand.label || brand.description"); expect(source).toContain("brand.logo || brand.icon || brand.label || brand.description");
expect(source.indexOf("brand.logo || brand.icon || brand.label || brand.description")).toBeLessThan(
source.indexOf('<slot name="brand" />'),
);
}); });
test("Navbar renders slotted utilities before its built-in actions", async () => { test("Navbar renders slotted utilities before its built-in actions", async () => {