fix(compiler): stop error {} from swallowing response {} bugs in api blocks

Client codegen chained .then().catch(), so a .catch() after .then()
caught exceptions thrown by the response body too. Switched to the
two-argument then(onFulfilled, onRejected) form, whose rejection
handler cannot see errors from the fulfilment handler.

SSR codegen wrapped both the transport call and the response-body eval
in the same try; only __wrnexusCallApi is now inside the try, and
__wrnexusEvalData runs after it, outside.

Also verifies (and locks in with a regression test) that GET query
numbers already coerce correctly through defineEndpoint + checkField,
and documents that in the typed-api-block spec.

editors/vscode/src/compiler.cjs

@@ -1,6 +1,6 @@
 "use strict";
 // Generated by scripts/build-editor-compiler.mjs. Do not edit directly.
-// WRN editor compiler source hash: fde135d610b595588974c7b88dc73ddf10c1da99e106a2c0a009be2707fc13a8
+// WRN editor compiler source hash: b0e3094d8c2a70ee2b34fe961c186b58de9527aa072ca12292b715d3d5f51c87
 // WRN editor compiler generator hash: a54ca847c758bc98d8e353ad6d70088df31de1820f6cf9d1c3462505f563e6b8
 // Generated with TypeScript: 6.0.3
 const __nodeRequire = require;
@@ -729,7 +729,7 @@ function apiBindings(ast) {
         const failure = error
             ? `(error) => { const status = error.status; const message = error.message; const data = error.data; ${error} }`
             : `(error) => { throw error; }`;
-        return `    ${JSON.stringify(block.name)}: async (input) => context.callApi(${JSON.stringify(block.path)}, ${JSON.stringify(block.method)}, input).then((data) => { ${response} }).catch(${failure})`;
+        return `    ${JSON.stringify(block.name)}: async (input) => context.callApi(${JSON.stringify(block.path)}, ${JSON.stringify(block.method)}, input).then((data) => { ${response} }, ${failure})`;
     });
     return members.length ? `const api = {\n${members.join(",\n")}\n  };` : "";
 }
@@ -1691,12 +1691,13 @@ async function __wrnexusResolveApiBinding(
   ctx: __WrnexusContext,
 ): Promise<unknown> {
   if (binding.errorBody) {
+    let data: unknown;
     try {
-      const data = await __wrnexusCallApi(binding.path, binding.method, ctx);
-      return __wrnexusEvalData(data, binding.body, binding.helpers, ctx);
+      data = await __wrnexusCallApi(binding.path, binding.method, ctx);
     } catch (err) {
       return __wrnexusEvalError(err, binding.errorBody, binding.helpers, ctx);
     }
+    return __wrnexusEvalData(data, binding.body, binding.helpers, ctx);
   }
   const data = await __wrnexusCallApi(binding.path, binding.method, ctx);
   return __wrnexusEvalData(data, binding.body, binding.helpers, ctx);